Fix to remove concatenated media names #6737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguerrero913
force-pushed
the
KCDR-4-Concatenated-media_names-and-media_recordings
branch
4 times, most recently
from
5c58780
to
87abb38
Compare
jamesaimonetti
requested changes
Sep 14, 2021
applications/cdr/src/cdr_util.erl
Outdated
| @@ -54,3 +59,16 @@ do_save_cdr(AccountMODb, Doc) -> | |||
| -spec register_views() -> 'ok'. | |||
| register_views() -> | |||
| kz_datamgr:register_views_from_folder('cdr'). | |||
|
|
|||
| -spec check_media_names(list()|kz_term:api_binary()) -> list(). | |||
| check_media_names(MediaNames) when is_list(MediaNames) -> | |||
There was a problem hiding this comment.
You can do this all in the function head:
check_media_name([HeadMN | TalMN]) ->Implies the is_list check, and binds the head and tail of the list, all in one go!
applications/cdr/src/cdr_util.erl
Outdated
| re:split(MediaNames, ","). | ||
|
|
||
| -spec check_last_media_name(list())->list(). | ||
| check_last_media_name([FirstMediaName | []])-> |
There was a problem hiding this comment.
[FirstMediaName | []] is the same as [FirstMediaName] - the | [] is implied.
| -spec check_last_media_name(list())->list(). | ||
| check_last_media_name([FirstMediaName | []])-> | ||
| re:split(FirstMediaName, ","); | ||
| check_last_media_name([FirstMediaName | LasttMediaName])-> |
There was a problem hiding this comment.
[FirstMediaName | LastMediaName] means that LastMediaName will be a list of binaries. Then you re:split on it below which is likely to crash.
Where are the tests showing this functionality working as expected?
| check_media_names(MediaNames) when is_list(MediaNames) -> | ||
| [HeadMN|TailMN] = MediaNames, | ||
| re:split(HeadMN, ",") ++ check_last_media_name(TailMN); | ||
| check_media_names(MediaNames) -> |
There was a problem hiding this comment.
Won't this crash is MediaNames is 'undefined' ?
oguerrero913
force-pushed
the
KCDR-4-Concatenated-media_names-and-media_recordings
branch
3 times, most recently
from
3bee0dd
to
e75d14d
Compare
oguerrero913
force-pushed
the
KCDR-4-Concatenated-media_names-and-media_recordings
branch
from
e75d14d
to
6361e05
Compare
jamesaimonetti
deleted the
KCDR-4-Concatenated-media_names-and-media_recordings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.